Skip to content

feat: async test stack cleanup — remove waiter + add sweeper Lambda#3930

Merged
vicheey merged 6 commits into
developfrom
async-stack-cleanup
May 27, 2026
Merged

feat: async test stack cleanup — remove waiter + add sweeper Lambda#3930
vicheey merged 6 commits into
developfrom
async-stack-cleanup

Conversation

@vicheey
Copy link
Copy Markdown
Contributor

@vicheey vicheey commented May 26, 2026

Changes

  • Remove CloudFormation waiter for stack deletion
  • Add sweeper Lambda for async test stack cleanup
  • Update permissions and refactor code

Commits

  • feat: async test stack cleanup — remove waiter + add sweeper Lambda
  • update permission and refactor code

vicheey added 3 commits May 23, 2026 04:33
Remove synchronous waiter from tearDown to prevent Lambda timeout kills.
Add TestStackSweeperFunction to companion stack that runs every 6h to
clean orphaned test stacks (with inline deep-clean for DELETE_FAILED)
and orphaned CloudWatch log groups.
@vicheey vicheey requested a review from a team as a code owner May 26, 2026 19:39
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bb1e69f..e9079fd
Files: 2
Comments: 2

Comment thread integration/setup/companion-stack.yaml Outdated
Comment thread integration/setup/companion-stack.yaml Outdated
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bb1e69f..83b2f1c
Files: 2
Comments: 2

Comment thread integration/setup/companion-stack.yaml Outdated
Comment thread integration/setup/companion-stack.yaml Outdated
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bb1e69f..05e16ea
Files: 2
Comments: 1

Comment thread integration/setup/companion-stack.yaml
Comment thread integration/setup/companion-stack.yaml Outdated
Comment thread integration/setup/companion-stack.yaml Outdated
Comment thread integration/setup/companion-stack.yaml
Comment thread integration/setup/companion-stack.yaml Outdated
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bb1e69f..9d80135
Files: 2
Comments: 2

Comment thread integration/setup/companion-stack.yaml
Comment thread integration/setup/companion-stack.yaml
@vicheey vicheey merged commit 34f5496 into develop May 27, 2026
8 of 9 checks passed
@vicheey vicheey deleted the async-stack-cleanup branch May 27, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants